diff options
| author | Steven Rostedt (Google) <rostedt@goodmis.org> | 2022-02-25 21:34:26 +0100 |
|---|---|---|
| committer | Steven Rostedt (Google) <rostedt@goodmis.org> | 2022-02-26 03:05:04 +0100 |
| commit | 851e99ebeec3f4a672bb5010cf1ece095acee447 (patch) | |
| tree | d8e8f5a9243e08cdc546d63d4dfdaad5e7e26cf4 /fs/ext4/mmp.c | |
| parent | tracing/osnoise: Make osnoise_main to sleep for microseconds (diff) | |
| download | linux-851e99ebeec3f4a672bb5010cf1ece095acee447.tar.xz linux-851e99ebeec3f4a672bb5010cf1ece095acee447.zip | |
tracefs: Set the group ownership in apply_options() not parse_options()
Al Viro brought it to my attention that the dentries may not be filled
when the parse_options() is called, causing the call to set_gid() to
possibly crash. It should only be called if parse_options() succeeds
totally anyway.
He suggested the logical place to do the update is in apply_options().
Link: https://lore.kernel.org/all/20220225165219.737025658@goodmis.org/
Link: https://lkml.kernel.org/r/20220225153426.1c4cab6b@gandalf.local.home
Cc: stable@vger.kernel.org
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Fixes: 48b27b6b5191 ("tracefs: Set all files to the same group ownership as the mount option")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Diffstat (limited to 'fs/ext4/mmp.c')
0 files changed, 0 insertions, 0 deletions