diff options
| author | Kemeng Shi <shikemeng@huaweicloud.com> | 2024-01-05 10:21:01 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2024-01-18 16:52:45 +0100 |
| commit | 2ffd2a6ad1d3a8213bb5805f45f49098fe615db1 (patch) | |
| tree | ab4f3a039b03fb8c3942f9446ea9d4f8877c7068 /fs/ext4/move_extent.c | |
| parent | ext4: remove unused return value of ext4_mb_release_group_pa (diff) | |
| download | linux-2ffd2a6ad1d3a8213bb5805f45f49098fe615db1.tar.xz linux-2ffd2a6ad1d3a8213bb5805f45f49098fe615db1.zip | |
ext4: remove unnecessary parameter "needed" in ext4_discard_preallocations
The "needed" controls the number of ext4_prealloc_space to discard in
ext4_discard_preallocations. Function ext4_discard_preallocations is
supposed to discard all non-used preallocated blocks when "needed"
is 0 and now ext4_discard_preallocations is always called with "needed"
= 0. Remove unnecessary parameter "needed" and remove all non-used
preallocated spaces in ext4_discard_preallocations to simplify the
code.
Note: If count of non-used preallocated spaces could be more than
UINT_MAX, there was a memory leak as some non-used preallocated
spaces are left ununsed and this commit will fix it. Otherwise,
there is no behavior change.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20240105092102.496631-9-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/move_extent.c')
| -rw-r--r-- | fs/ext4/move_extent.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index 391efa6d4c56..7cd4afa4de1d 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -686,8 +686,8 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp, __u64 orig_blk, out: if (*moved_len) { - ext4_discard_preallocations(orig_inode, 0); - ext4_discard_preallocations(donor_inode, 0); + ext4_discard_preallocations(orig_inode); + ext4_discard_preallocations(donor_inode); } ext4_free_ext_path(path); |