diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2016-03-26 21:14:34 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2016-03-26 21:14:34 +0100 |
| commit | c9af28fdd44922a6c10c9f8315718408af98e315 (patch) | |
| tree | b5bc491b5d141ba710bc6da44b00125b8d5d589c /fs/ext4/readpage.c | |
| parent | ext4: check if in-inode xattr is corrupted in ext4_expand_extra_isize_ea() (diff) | |
| download | linux-c9af28fdd44922a6c10c9f8315718408af98e315.tar.xz linux-c9af28fdd44922a6c10c9f8315718408af98e315.zip | |
ext4 crypto: don't let data integrity writebacks fail with ENOMEM
We don't want the writeback triggered from the journal commit (in
data=writeback mode) to cause the journal to abort due to
generic_writepages() returning an ENOMEM error. In addition, if
fsync() fails with ENOMEM, most applications will probably not do the
right thing.
So if we are doing a data integrity sync, and ext4_encrypt() returns
ENOMEM, we will submit any queued I/O to date, and then retry the
allocation using GFP_NOFAIL.
Google-Bug-Id: 27641567
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/readpage.c')
| -rw-r--r-- | fs/ext4/readpage.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c index 5dc5e95063de..bc7642f57dc8 100644 --- a/fs/ext4/readpage.c +++ b/fs/ext4/readpage.c @@ -279,7 +279,7 @@ int ext4_mpage_readpages(struct address_space *mapping, if (ext4_encrypted_inode(inode) && S_ISREG(inode->i_mode)) { - ctx = ext4_get_crypto_ctx(inode); + ctx = ext4_get_crypto_ctx(inode, GFP_NOFS); if (IS_ERR(ctx)) goto set_error_page; } |