diff options
| author | Jan Kara <jack@suse.cz> | 2013-04-09 15:21:41 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2013-04-09 15:21:41 +0200 |
| commit | bcb1385096caf421363d47e735acda940cb1e12b (patch) | |
| tree | 64f43332e262c078b74aedb1d062aec293176b6f /fs/ext4 | |
| parent | ext4: fix incorrect lock ordering for ext4_ind_migrate (diff) | |
| download | linux-bcb1385096caf421363d47e735acda940cb1e12b.tar.xz linux-bcb1385096caf421363d47e735acda940cb1e12b.zip | |
ext4: fix deadlock with quota feature
We didn't mark hidden quota files with S_NOQUOTA flag and thus quota was
accounted even for quota files. Thus we could recurse back to quota code
when adding new blocks to quota file which can easily deadlock. Mark
hidden quota files properly.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/super.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 525beb6e3e1e..968ca9369175 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -4953,6 +4953,8 @@ static int ext4_quota_enable(struct super_block *sb, int type, int format_id, return PTR_ERR(qf_inode); } + /* Don't account quota for quota files to avoid recursion */ + qf_inode->i_flags |= S_NOQUOTA; err = dquot_enable(qf_inode, type, format_id, flags); iput(qf_inode); |