diff options
| author | Akira Fujita <a-fujita@rs.jp.nec.com> | 2009-11-23 13:24:41 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2009-11-23 13:24:41 +0100 |
| commit | 49bd22bc4d603a2a4fc2a6a60e156cbea52eb494 (patch) | |
| tree | b1a8d6b5be2ff4a72f2274bf01c15922ad9a0e65 /fs/ext4 | |
| parent | ext4: fix lock order problem in ext4_move_extents() (diff) | |
| download | linux-49bd22bc4d603a2a4fc2a6a60e156cbea52eb494.tar.xz linux-49bd22bc4d603a2a4fc2a6a60e156cbea52eb494.zip | |
ext4: fix possible recursive locking warning in EXT4_IOC_MOVE_EXT
If CONFIG_PROVE_LOCKING is enabled, the double_down_write_data_sem()
will trigger a false-positive warning of a recursive lock. Since we
take i_data_sem for the two inodes ordered by their inode numbers,
this isn't a problem. Use of down_write_nested() will notify the lock
dependency checker machinery that there is no problem here.
This problem was reported by Brian Rogers:
http://marc.info/?l=linux-ext4&m=125115356928011&w=1
Reported-by: Brian Rogers <brian@xyzw.org>
Signed-off-by: Akira Fujita <a-fujita@rs.jp.nec.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/move_extent.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c index a7410b34c5ed..2ca6aa3f34e6 100644 --- a/fs/ext4/move_extent.c +++ b/fs/ext4/move_extent.c @@ -189,7 +189,7 @@ double_down_write_data_sem(struct inode *orig_inode, struct inode *donor_inode) } down_write(&EXT4_I(first)->i_data_sem); - down_write(&EXT4_I(second)->i_data_sem); + down_write_nested(&EXT4_I(second)->i_data_sem, SINGLE_DEPTH_NESTING); } /** |