diff options
| author | Tahsin Erdogan <tahsin@google.com> | 2017-06-22 03:39:38 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2017-06-22 03:39:38 +0200 |
| commit | 1e7d359d710e84b996bd034f4ecc7c721e445603 (patch) | |
| tree | ccd2027e2c780b9825e39975cedf381297825135 /fs/ext4 | |
| parent | ext4: call journal revoke when freeing ea_inode blocks (diff) | |
| download | linux-1e7d359d710e84b996bd034f4ecc7c721e445603.tar.xz linux-1e7d359d710e84b996bd034f4ecc7c721e445603.zip | |
ext4: fix ref counting for ea_inode
The ref count on ea_inode is incremented by
ext4_xattr_inode_orphan_add() which is supposed to be decremented by
ext4_xattr_inode_array_free(). The decrement is conditioned on whether
the ea_inode is currently on the orphan list. However, the orphan list
addition only happens when journaling is enabled. In non-journaled case,r
we fail to release the ref count causing an error message like below.
"VFS: Busy inodes after unmount of sdb. Self-destruct in 5 seconds.
Have a nice day..."
Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/xattr.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index a29e68293d59..53698f8a6e54 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -2096,8 +2096,7 @@ ext4_xattr_inode_array_free(struct inode *inode, if (err) continue; /* for inode's i_count get from ext4_xattr_delete_inode */ - if (!list_empty(&EXT4_I(ea_inode)->i_orphan)) - iput(ea_inode); + iput(ea_inode); clear_nlink(ea_inode); iput(ea_inode); } |