diff options
| author | Chunguang Xu <brookxu@tencent.com> | 2020-11-07 16:58:18 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2020-12-17 19:30:09 +0100 |
| commit | cca415537244f6102cbb09b5b90db6ae2c953bdd (patch) | |
| tree | 8dce47d4ded574925459bcc9eb47808063a9171b /fs/ext4 | |
| parent | ext4: delete nonsensical (commented-out) code inside ext4_xattr_block_set() (diff) | |
| download | linux-cca415537244f6102cbb09b5b90db6ae2c953bdd.tar.xz linux-cca415537244f6102cbb09b5b90db6ae2c953bdd.zip | |
ext4: fix a memory leak of ext4_free_data
When freeing metadata, we will create an ext4_free_data and
insert it into the pending free list. After the current
transaction is committed, the object will be freed.
ext4_mb_free_metadata() will check whether the area to be freed
overlaps with the pending free list. If true, return directly. At this
time, ext4_free_data is leaked. Fortunately, the probability of this
problem is small, since it only occurs if the file system is corrupted
such that a block is claimed by more one inode and those inodes are
deleted within a single jbd2 transaction.
Signed-off-by: Chunguang Xu <brookxu@tencent.com>
Link: https://lore.kernel.org/r/1604764698-4269-8-git-send-email-brookxu@tencent.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/mballoc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 29dfeb043050..77815cd110b2 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -5103,6 +5103,7 @@ ext4_mb_free_metadata(handle_t *handle, struct ext4_buddy *e4b, ext4_group_first_block_no(sb, group) + EXT4_C2B(sbi, cluster), "Block already on to-be-freed list"); + kmem_cache_free(ext4_free_data_cachep, new_entry); return 0; } } |