diff options
| author | Vasily Averin <vvs@virtuozzo.com> | 2018-11-07 17:07:01 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2018-11-07 17:07:01 +0100 |
| commit | 45ae932d246f721e6584430017176cbcadfde610 (patch) | |
| tree | 94f7661d93356a28a32192cc668603b2e8d9e987 /fs/ext4 | |
| parent | ext4: fix buffer leak in ext4_xattr_get_block() on error path (diff) | |
| download | linux-45ae932d246f721e6584430017176cbcadfde610.tar.xz linux-45ae932d246f721e6584430017176cbcadfde610.zip | |
ext4: release bs.bh before re-using in ext4_xattr_block_find()
bs.bh was taken in previous ext4_xattr_block_find() call,
it should be released before re-using
Fixes: 7e01c8e5420b ("ext3/4: fix uninitialized bs in ...")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 2.6.26
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/xattr.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 07c3a115f7ae..07b9a335c8eb 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -2395,6 +2395,8 @@ retry_inode: error = ext4_xattr_block_set(handle, inode, &i, &bs); } else if (error == -ENOSPC) { if (EXT4_I(inode)->i_file_acl && !bs.s.base) { + brelse(bs.bh); + bs.bh = NULL; error = ext4_xattr_block_find(inode, &i, &bs); if (error) goto cleanup; |