diff options
| author | Thadeu Lima de Souza Cascardo <cascardo@igalia.com> | 2024-08-21 17:23:22 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2024-09-04 04:12:16 +0200 |
| commit | 4d231b91a944f3cab355fce65af5871fb5d7735b (patch) | |
| tree | e262f05abd4f602d26e9a7bfa8a59a2ba2bb76a2 /fs/ext4 | |
| parent | ext4: ext4_search_dir should return a proper error (diff) | |
| download | linux-4d231b91a944f3cab355fce65af5871fb5d7735b.tar.xz linux-4d231b91a944f3cab355fce65af5871fb5d7735b.zip | |
ext4: return error on ext4_find_inline_entry
In case of errors when reading an inode from disk or traversing inline
directory entries, return an error-encoded ERR_PTR instead of returning
NULL. ext4_find_inline_entry only caller, __ext4_find_entry already returns
such encoded errors.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Link: https://patch.msgid.link/20240821152324.3621860-3-cascardo@igalia.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/inline.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index e7a09a99837b..7b98b1bf1dc9 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -1669,8 +1669,9 @@ struct buffer_head *ext4_find_inline_entry(struct inode *dir, void *inline_start; int inline_size; - if (ext4_get_inode_loc(dir, &iloc)) - return NULL; + ret = ext4_get_inode_loc(dir, &iloc); + if (ret) + return ERR_PTR(ret); down_read(&EXT4_I(dir)->xattr_sem); if (!ext4_has_inline_data(dir)) { @@ -1701,7 +1702,10 @@ struct buffer_head *ext4_find_inline_entry(struct inode *dir, out: brelse(iloc.bh); - iloc.bh = NULL; + if (ret < 0) + iloc.bh = ERR_PTR(ret); + else + iloc.bh = NULL; out_find: up_read(&EXT4_I(dir)->xattr_sem); return iloc.bh; |