diff options
| author | Dave Hansen <haveblue@us.ibm.com> | 2007-07-18 14:33:51 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2007-07-18 14:33:51 +0200 |
| commit | d699594dc151c664a2b307e680a3cd9b7145fd83 (patch) | |
| tree | 9b3e50339d09ea5a7786369fda4da6ecf597d4dd /fs/ext4 | |
| parent | ext4: Use is_power_of_2() (diff) | |
| download | linux-d699594dc151c664a2b307e680a3cd9b7145fd83.tar.xz linux-d699594dc151c664a2b307e680a3cd9b7145fd83.zip | |
ext4: remove extra IS_RDONLY() check
ext4_change_inode_journal_flag() is only called from one location:
ext4_ioctl(EXT3_IOC_SETFLAGS). That ioctl case already has a IS_RDONLY()
call in it so this one is superfluous.
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 125aca714685..de26c25d6a18 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -3275,7 +3275,7 @@ int ext4_change_inode_journal_flag(struct inode *inode, int val) */ journal = EXT4_JOURNAL(inode); - if (is_journal_aborted(journal) || IS_RDONLY(inode)) + if (is_journal_aborted(journal)) return -EROFS; jbd2_journal_lock_updates(journal); |