diff options
| author | Nicholas Krause <xerofoify@gmail.com> | 2015-09-06 14:28:46 +0200 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2015-10-10 01:20:49 +0200 |
| commit | 538e17e7e96e14f76bb82dd83290a5315da70c3b (patch) | |
| tree | 2a6e3002bd04688306b3a6144e18c018e33ae53b /fs/f2fs/file.c | |
| parent | f2fs: trace in batches extent info update (diff) | |
| download | linux-538e17e7e96e14f76bb82dd83290a5315da70c3b.tar.xz linux-538e17e7e96e14f76bb82dd83290a5315da70c3b.zip | |
f2fs: fix incorrect return statement in the function f2fs_ioc_release_volatile_write
This fixes the incorrect return statement at the end of the function
f2fs_ioc_release_volatile_write's body for returning zero as this is
incorrect due to the function call before this return statement to
the function punch_hole being able to fail and we should return this
function's return fail directly in order to signal to callers of the
function f2fs_ioc_release_volatile if a failure arises with this call
to punch_hole fails.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Reviewed-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | fs/f2fs/file.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 8120f8685141..b2fab9e2c09b 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1437,8 +1437,7 @@ static int f2fs_ioc_release_volatile_write(struct file *filp) if (!f2fs_is_first_block_written(inode)) return truncate_partial_data_page(inode, 0, true); - punch_hole(inode, 0, F2FS_BLKSIZE); - return 0; + return punch_hole(inode, 0, F2FS_BLKSIZE); } static int f2fs_ioc_abort_volatile_write(struct file *filp) |