diff options
| author | Chao Yu <chao2.yu@samsung.com> | 2015-07-28 12:36:47 +0200 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2015-08-05 17:19:21 +0200 |
| commit | e90c2d2850d9d034e814a328725a4b15878f0357 (patch) | |
| tree | b9709c15f56af0c3d76dd717033a1e08e25ac2ee /fs/f2fs/recovery.c | |
| parent | f2fs: fix to release inode page correctly (diff) | |
| download | linux-e90c2d2850d9d034e814a328725a4b15878f0357.tar.xz linux-e90c2d2850d9d034e814a328725a4b15878f0357.zip | |
f2fs: invalidate temporary meta page
To avoid meeting garbage data in next free node block at the end of warm
node chain when doing recovery, we will try to zero out that invalid block.
If the device is not support discard, our way for zeroing out block is:
grabbing a temporary zeroed page in meta inode, then, issue write request
with this page.
But, we forget to release that temporary page, so our memory usage will
increase without gaining any hit ratio benefit, so it's better to free it
for saving memory.
Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/recovery.c')
| -rw-r--r-- | fs/f2fs/recovery.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c index 24a8c1d4f45f..07a36e413ace 100644 --- a/fs/f2fs/recovery.c +++ b/fs/f2fs/recovery.c @@ -561,11 +561,20 @@ out: clear_sbi_flag(sbi, SBI_POR_DOING); if (err) { - discard_next_dnode(sbi, blkaddr); + bool invalidate = false; + + if (discard_next_dnode(sbi, blkaddr)) + invalidate = true; /* Flush all the NAT/SIT pages */ while (get_pages(sbi, F2FS_DIRTY_META)) sync_meta_pages(sbi, META, LONG_MAX); + + /* invalidate temporary meta page */ + if (invalidate) + invalidate_mapping_pages(META_MAPPING(sbi), + blkaddr, blkaddr); + set_ckpt_flags(sbi->ckpt, CP_ERROR_FLAG); mutex_unlock(&sbi->cp_mutex); } else if (need_writecp) { |