diff options
| author | Chao Yu <yuchao0@huawei.com> | 2020-02-17 10:45:44 +0100 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2020-03-19 19:41:26 +0100 |
| commit | 5df7731f60c2a933695a68d732f8b39fca788de6 (patch) | |
| tree | c1567ecaa25163fe72300091d1182c531583cbc0 /fs/f2fs/super.c | |
| parent | f2fs: skip GC when section is full (diff) | |
| download | linux-5df7731f60c2a933695a68d732f8b39fca788de6.tar.xz linux-5df7731f60c2a933695a68d732f8b39fca788de6.zip | |
f2fs: introduce DEFAULT_IO_TIMEOUT
As Geert Uytterhoeven reported:
for parameter HZ/50 in congestion_wait(BLK_RW_ASYNC, HZ/50);
On some platforms, HZ can be less than 50, then unexpected 0 timeout
jiffies will be set in congestion_wait().
This patch introduces a macro DEFAULT_IO_TIMEOUT to wrap a determinate
value with msecs_to_jiffies(20) to instead HZ/50 to avoid such issue.
Quoted from Geert Uytterhoeven:
"A timeout of HZ means 1 second.
HZ/50 means 20 ms, but has the risk of being zero, if HZ < 50.
If you want to use a timeout of 20 ms, you best use msecs_to_jiffies(20),
as that takes care of the special cases, and never returns 0."
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/super.c')
| -rw-r--r-- | fs/f2fs/super.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index cdcb80f9b3d0..36539afae1e5 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -1885,7 +1885,8 @@ repeat: page = read_cache_page_gfp(mapping, blkidx, GFP_NOFS); if (IS_ERR(page)) { if (PTR_ERR(page) == -ENOMEM) { - congestion_wait(BLK_RW_ASYNC, HZ/50); + congestion_wait(BLK_RW_ASYNC, + DEFAULT_IO_TIMEOUT); goto repeat; } set_sbi_flag(F2FS_SB(sb), SBI_QUOTA_NEED_REPAIR); @@ -1939,7 +1940,8 @@ retry: &page, NULL); if (unlikely(err)) { if (err == -ENOMEM) { - congestion_wait(BLK_RW_ASYNC, HZ/50); + congestion_wait(BLK_RW_ASYNC, + DEFAULT_IO_TIMEOUT); goto retry; } set_sbi_flag(F2FS_SB(sb), SBI_QUOTA_NEED_REPAIR); |