summaryrefslogtreecommitdiffstats
path: root/fs/f2fs
diff options
context:
space:
mode:
authorChao Yu <chao@kernel.org>2023-04-05 16:45:36 +0200
committerJaegeuk Kim <jaegeuk@kernel.org>2023-04-14 01:37:57 +0200
commit935fc6fa6466cf18dd72dd1518ebc7bfc4cd58a4 (patch)
tree1627f8818c8785771acd809fb7fb0fff4617dbc6 /fs/f2fs
parentf2fs: fix to check return value of f2fs_do_truncate_blocks() (diff)
downloadlinux-935fc6fa6466cf18dd72dd1518ebc7bfc4cd58a4.tar.xz
linux-935fc6fa6466cf18dd72dd1518ebc7bfc4cd58a4.zip
f2fs: fix to check return value of inc_valid_block_count()
In __replace_atomic_write_block(), we missed to check return value of inc_valid_block_count(), for extreme testcase that f2fs image is run out of space, it may cause inconsistent status in between SIT table and total valid block count. Cc: Daeho Jeong <daehojeong@google.com> Fixes: 3db1de0e582c ("f2fs: change the current atomic write way") Signed-off-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs')
-rw-r--r--fs/f2fs/segment.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 84e2e558ea99..82430f80c5da 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -246,10 +246,16 @@ retry:
} else {
blkcnt_t count = 1;
+ err = inc_valid_block_count(sbi, inode, &count);
+ if (err) {
+ f2fs_put_dnode(&dn);
+ return err;
+ }
+
*old_addr = dn.data_blkaddr;
f2fs_truncate_data_blocks_range(&dn, 1);
dec_valid_block_count(sbi, F2FS_I(inode)->cow_inode, count);
- inc_valid_block_count(sbi, inode, &count);
+
f2fs_replace_block(sbi, &dn, dn.data_blkaddr, new_addr,
ni.version, true, false);
}