diff options
author | Eric W. Biederman <ebiederm@xmission.com> | 2018-09-25 11:27:20 +0200 |
---|---|---|
committer | Eric W. Biederman <ebiederm@xmission.com> | 2018-10-03 16:47:43 +0200 |
commit | ae7795bc6187a15ec51cf258abae656a625f9980 (patch) | |
tree | 2456aa85c6b4be1ac58e272393056c0edbee038a /fs/fcntl.c | |
parent | signal: Introduce copy_siginfo_from_user and use it's return value (diff) | |
download | linux-ae7795bc6187a15ec51cf258abae656a625f9980.tar.xz linux-ae7795bc6187a15ec51cf258abae656a625f9980.zip |
signal: Distinguish between kernel_siginfo and siginfo
Linus recently observed that if we did not worry about the padding
member in struct siginfo it is only about 48 bytes, and 48 bytes is
much nicer than 128 bytes for allocating on the stack and copying
around in the kernel.
The obvious thing of only adding the padding when userspace is
including siginfo.h won't work as there are sigframe definitions in
the kernel that embed struct siginfo.
So split siginfo in two; kernel_siginfo and siginfo. Keeping the
traditional name for the userspace definition. While the version that
is used internally to the kernel and ultimately will not be padded to
128 bytes is called kernel_siginfo.
The definition of struct kernel_siginfo I have put in include/signal_types.h
A set of buildtime checks has been added to verify the two structures have
the same field offsets.
To make it easy to verify the change kernel_siginfo retains the same
size as siginfo. The reduction in size comes in a following change.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'fs/fcntl.c')
-rw-r--r-- | fs/fcntl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/fcntl.c b/fs/fcntl.c index 4137d96534a6..083185174c6d 100644 --- a/fs/fcntl.c +++ b/fs/fcntl.c @@ -735,7 +735,7 @@ static void send_sigio_to_task(struct task_struct *p, return; switch (signum) { - siginfo_t si; + kernel_siginfo_t si; default: /* Queue a rt signal with the appropriate fd as its value. We use SI_SIGIO as the source, not |