diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2020-11-21 00:14:41 +0100 |
|---|---|---|
| committer | Eric W. Biederman <ebiederm@xmission.com> | 2020-12-10 19:42:59 +0100 |
| commit | fa67bf885e5211c7dce9514ef2877212c0a5e09e (patch) | |
| tree | 8390573b7ab598a4ddb548f9d2ede8f3ec7bbd2f /fs/file.c | |
| parent | file: Rename __close_fd_get_file close_fd_get_file (diff) | |
| download | linux-fa67bf885e5211c7dce9514ef2877212c0a5e09e.tar.xz linux-fa67bf885e5211c7dce9514ef2877212c0a5e09e.zip | |
file: Remove get_files_struct
When discussing[1] exec and posix file locks it was realized that none
of the callers of get_files_struct fundamentally needed to call
get_files_struct, and that by switching them to helper functions
instead it will both simplify their code and remove unnecessary
increments of files_struct.count. Those unnecessary increments can
result in exec unnecessarily unsharing files_struct which breaking
posix locks, and it can result in fget_light having to fallback to
fget reducing system performance.
Now that get_files_struct has no more users and can not cause the
problems for posix file locking and fget_light remove get_files_struct
so that it does not gain any new users.
[1] https://lkml.kernel.org/r/20180915160423.GA31461@redhat.com
Suggested-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
v1: https://lkml.kernel.org/r/20200817220425.9389-13-ebiederm@xmission.com
Link: https://lkml.kernel.org/r/20201120231441.29911-24-ebiederm@xmission.com
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Diffstat (limited to 'fs/file.c')
| -rw-r--r-- | fs/file.c | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/fs/file.c b/fs/file.c index 947ac6d5602f..412033d8cfdf 100644 --- a/fs/file.c +++ b/fs/file.c @@ -411,19 +411,6 @@ static struct fdtable *close_files(struct files_struct * files) return fdt; } -struct files_struct *get_files_struct(struct task_struct *task) -{ - struct files_struct *files; - - task_lock(task); - files = task->files; - if (files) - atomic_inc(&files->count); - task_unlock(task); - - return files; -} - void put_files_struct(struct files_struct *files) { if (atomic_dec_and_test(&files->count)) { |