diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2009-04-24 01:02:45 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-04-24 16:39:45 +0200 |
| commit | 437f7fdb607f32b737e4da9f14bebcfdac2c90c3 (patch) | |
| tree | 2064149ad4406774bd3b1ade60782980206f2e82 /fs/filesystems.c | |
| parent | do_execve() must not clear fs->in_exec if it was set by another thread (diff) | |
| download | linux-437f7fdb607f32b737e4da9f14bebcfdac2c90c3.tar.xz linux-437f7fdb607f32b737e4da9f14bebcfdac2c90c3.zip | |
check_unsafe_exec: s/lock_task_sighand/rcu_read_lock/
write_lock(¤t->fs->lock) guarantees we can't wrongly miss
LSM_UNSAFE_SHARE, this is what we care about. Use rcu_read_lock()
instead of ->siglock to iterate over the sub-threads. We must see
all CLONE_THREAD|CLONE_FS threads which didn't pass exit_fs(), it
takes fs->lock too.
With or without this patch we can miss the freshly cloned thread
and set LSM_UNSAFE_SHARE, we don't care.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
[ Fixed lock/unlock typo - Hugh ]
Acked-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/filesystems.c')
0 files changed, 0 insertions, 0 deletions