diff options
author | Darrick J. Wong <darrick.wong@oracle.com> | 2018-05-31 04:43:53 +0200 |
---|---|---|
committer | Darrick J. Wong <darrick.wong@oracle.com> | 2018-05-31 04:43:53 +0200 |
commit | 829bc787c1a0403e4d886296dd4d90c5f9c1744a (patch) | |
tree | 170ad56bc430b8918c259a578cbef614687e28f6 /fs/fs-writeback.c | |
parent | xfs: cap the length of deduplication requests (diff) | |
download | linux-829bc787c1a0403e4d886296dd4d90c5f9c1744a.tar.xz linux-829bc787c1a0403e4d886296dd4d90c5f9c1744a.zip |
fs: clear writeback errors in inode_init_always
In inode_init_always(), we clear the inode mapping flags, which clears
any retained error (AS_EIO, AS_ENOSPC) bits. Unfortunately, we do not
also clear wb_err, which means that old mapping errors can leak through
to new inodes.
This is crucial for the XFS inode allocation path because we recycle old
in-core inodes and we do not want error state from an old file to leak
into the new file. This bug was discovered by running generic/036 and
generic/047 in a loop and noticing that the EIOs generated by the
collision of direct and buffered writes in generic/036 would survive the
remount between 036 and 047, and get reported to the fsyncs (on
different files!) in generic/047.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Diffstat (limited to 'fs/fs-writeback.c')
0 files changed, 0 insertions, 0 deletions