diff options
| author | Maxim Korotkov <korotkov.maxim.s@gmail.com> | 2023-01-19 11:44:43 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2023-04-28 18:41:32 +0200 |
| commit | 3e46c89c74f2c38e5337d2cf44b0b551adff1cb4 (patch) | |
| tree | c9ff634160f77d4ad22f6b61d518ac9c1ae0c683 /fs/fs-writeback.c | |
| parent | Merge tag 'md-next-2023-04-28' of https://git.kernel.org/pub/scm/linux/kernel... (diff) | |
| download | linux-3e46c89c74f2c38e5337d2cf44b0b551adff1cb4.tar.xz linux-3e46c89c74f2c38e5337d2cf44b0b551adff1cb4.zip | |
writeback: fix call of incorrect macro
the variable 'history' is of type u16, it may be an error
that the hweight32 macro was used for it
I guess macro hweight16 should be used
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 2a81490811d0 ("writeback: implement foreign cgroup inode detection")
Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230119104443.3002-1-korotkov.maxim.s@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/fs-writeback.c')
| -rw-r--r-- | fs/fs-writeback.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 195dc23e0d83..6faeb45234ed 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -829,7 +829,7 @@ void wbc_detach_inode(struct writeback_control *wbc) * is okay. The main goal is avoiding keeping an inode on * the wrong wb for an extended period of time. */ - if (hweight32(history) > WB_FRN_HIST_THR_SLOTS) + if (hweight16(history) > WB_FRN_HIST_THR_SLOTS) inode_switch_wbs(inode, max_id); } |