diff options
author | Alexander Aring <aahringo@redhat.com> | 2020-11-23 00:10:24 +0100 |
---|---|---|
committer | Andreas Gruenbacher <agruenba@redhat.com> | 2020-11-24 23:45:58 +0100 |
commit | 16e6281b6b22b0178eab95c6a82502d7b10f67b8 (patch) | |
tree | 48ca6ba8ee370a7c40b7a5e99d84c394341d39a0 /fs/fs_parser.c | |
parent | Linux 5.10-rc5 (diff) | |
download | linux-16e6281b6b22b0178eab95c6a82502d7b10f67b8.tar.xz linux-16e6281b6b22b0178eab95c6a82502d7b10f67b8.zip |
gfs2: Fix deadlock dumping resource group glocks
Commit 0e539ca1bbbe ("gfs2: Fix NULL pointer dereference in gfs2_rgrp_dump")
introduced additional locking in gfs2_rgrp_go_dump, which is also used for
dumping resource group glocks via debugfs. However, on that code path, the
glock spin lock is already taken in dump_glock, and taking it again in
gfs2_glock2rgrp leads to deadlock. This can be reproduced with:
$ mkfs.gfs2 -O -p lock_nolock /dev/FOO
$ mount /dev/FOO /mnt/foo
$ touch /mnt/foo/bar
$ cat /sys/kernel/debug/gfs2/FOO/glocks
Fix that by not taking the glock spin lock inside the go_dump callback.
Fixes: 0e539ca1bbbe ("gfs2: Fix NULL pointer dereference in gfs2_rgrp_dump")
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'fs/fs_parser.c')
0 files changed, 0 insertions, 0 deletions