diff options
| author | Miklos Szeredi <mszeredi@suse.cz> | 2007-10-18 12:06:58 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-18 23:37:29 +0200 |
| commit | e57ac68378a287d6336d187b26971f35f7ee7251 (patch) | |
| tree | 12b9ae8cc79af2d0100582e6f933aba0f4619663 /fs/fuse/dir.c | |
| parent | ext3: fix setup_new_group_blocks locking (diff) | |
| download | linux-e57ac68378a287d6336d187b26971f35f7ee7251.tar.xz linux-e57ac68378a287d6336d187b26971f35f7ee7251.zip | |
fuse: fix allowing operations
The following operation didn't check if sending the request was allowed:
setattr
listxattr
statfs
Some other operations don't explicitly do the check, but VFS calls
->permission() which checks this.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/fuse/dir.c')
| -rw-r--r-- | fs/fuse/dir.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index d1acab931330..b18e06daeffb 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c @@ -721,7 +721,7 @@ static int fuse_refresh_attributes(struct inode *inode) * for which the owner of the mount has ptrace privilege. This * excludes processes started by other users, suid or sgid processes. */ -static int fuse_allow_task(struct fuse_conn *fc, struct task_struct *task) +int fuse_allow_task(struct fuse_conn *fc, struct task_struct *task) { if (fc->flags & FUSE_ALLOW_OTHER) return 1; @@ -1005,6 +1005,9 @@ static int fuse_setattr(struct dentry *entry, struct iattr *attr) struct fuse_attr_out outarg; int err; + if (!fuse_allow_task(fc, current)) + return -EACCES; + if (fc->flags & FUSE_DEFAULT_PERMISSIONS) { err = inode_change_ok(inode, attr); if (err) @@ -1172,6 +1175,9 @@ static ssize_t fuse_listxattr(struct dentry *entry, char *list, size_t size) struct fuse_getxattr_out outarg; ssize_t ret; + if (!fuse_allow_task(fc, current)) + return -EACCES; + if (fc->no_listxattr) return -EOPNOTSUPP; |