diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2019-09-03 15:10:05 +0200 |
|---|---|---|
| committer | Andreas Gruenbacher <agruenba@redhat.com> | 2019-09-04 20:22:17 +0200 |
| commit | bccaef90738581038ee609e946f36812bd6fb1b3 (patch) | |
| tree | 2cb18b48bc17f3e6e0d918deb799d422a4ab89e9 /fs/gfs2/dir.c | |
| parent | gfs2: Minor PAGE_SIZE arithmetic cleanups (diff) | |
| download | linux-bccaef90738581038ee609e946f36812bd6fb1b3.tar.xz linux-bccaef90738581038ee609e946f36812bd6fb1b3.zip | |
gfs2: Delete an unnecessary check before brelse()
The brelse() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
[The same applies to brelse() in gfs2_dir_no_add (which Coccinelle
apparently missed), so fix that as well.]
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'fs/gfs2/dir.c')
| -rw-r--r-- | fs/gfs2/dir.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c index 6f35d19eec25..eb9c0578978f 100644 --- a/fs/gfs2/dir.c +++ b/fs/gfs2/dir.c @@ -1463,8 +1463,7 @@ static int gfs2_dir_read_leaf(struct inode *inode, struct dir_context *ctx, sort_offset : entries, copied); out_free: for(i = 0; i < leaf; i++) - if (larr[i]) - brelse(larr[i]); + brelse(larr[i]); kvfree(larr); out: return error; |