diff options
author | Abhi Das <adas@redhat.com> | 2014-09-19 04:40:28 +0200 |
---|---|---|
committer | Steven Whitehouse <swhiteho@redhat.com> | 2014-09-19 11:45:18 +0200 |
commit | 00a158be83839f2d5370612d633eb2643ddf844e (patch) | |
tree | afa1b3a2f820fe5b88af29975fc98004dd10bcdc /fs/gfs2/dir.h | |
parent | Merge tag 'gfs2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/steve... (diff) | |
download | linux-00a158be83839f2d5370612d633eb2643ddf844e.tar.xz linux-00a158be83839f2d5370612d633eb2643ddf844e.zip |
GFS2: fix bad inode i_goal values during block allocation
This patch checks if i_goal is either zero or if doesn't exist
within any rgrp (i.e gfs2_blk2rgrpd() returns NULL). If so, it
assigns the ip->i_no_addr block as the i_goal.
There are two scenarios where a bad i_goal can result in a
-EBADSLT error.
1. Attempting to allocate to an existing inode:
Control reaches gfs2_inplace_reserve() and ip->i_goal is bad.
We need to fix i_goal here.
2. A new inode is created in a directory whose i_goal is hosed:
In this case, the parent dir's i_goal is copied onto the new
inode. Since the new inode is not yet created, the ip->i_no_addr
field is invalid and so, the fix in gfs2_inplace_reserve() as per
1) won't work in this scenario. We need to catch and fix it sooner
in the parent dir itself (gfs2_create_inode()), before it is
copied to the new inode.
Signed-off-by: Abhi Das <adas@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/dir.h')
0 files changed, 0 insertions, 0 deletions