diff options
| author | Steven Whitehouse <swhiteho@redhat.com> | 2013-11-21 19:47:57 +0100 |
|---|---|---|
| committer | Steven Whitehouse <swhiteho@redhat.com> | 2013-11-21 19:47:57 +0100 |
| commit | ea0341e071527d5cec350917b01ab901af09d758 (patch) | |
| tree | 93897b0b02f7d689334e77915e111d8ba4a0b9ba /fs/gfs2/inode.c | |
| parent | GFS2: fix potential NULL pointer dereference (diff) | |
| download | linux-ea0341e071527d5cec350917b01ab901af09d758.tar.xz linux-ea0341e071527d5cec350917b01ab901af09d758.zip | |
GFS2: Fix ref count bug relating to atomic_open
In the case that atomic_open calls finish_no_open() with
the dentry that was supplied to gfs2_atomic_open() an
extra reference count is required. This patch fixes that
issue preventing a bug trap triggering at umount time.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/inode.c')
| -rw-r--r-- | fs/gfs2/inode.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 1615df16cf4e..7119504159f1 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c @@ -1171,8 +1171,11 @@ static int gfs2_atomic_open(struct inode *dir, struct dentry *dentry, if (d != NULL) dentry = d; if (dentry->d_inode) { - if (!(*opened & FILE_OPENED)) + if (!(*opened & FILE_OPENED)) { + if (d == NULL) + dget(dentry); return finish_no_open(file, dentry); + } dput(d); return 0; } |