diff options
author | Bob Peterson <rpeterso@redhat.com> | 2019-11-13 20:47:02 +0100 |
---|---|---|
committer | Bob Peterson <rpeterso@redhat.com> | 2020-02-27 14:53:18 +0100 |
commit | 9ff78289356af640941bbb0dd3f46af2063f0046 (patch) | |
tree | 2e973bf0e97bafa63d3cae19421d35692bd5e85d /fs/gfs2/log.c | |
parent | gfs2: Check for log write errors before telling dlm to unlock (diff) | |
download | linux-9ff78289356af640941bbb0dd3f46af2063f0046.tar.xz linux-9ff78289356af640941bbb0dd3f46af2063f0046.zip |
gfs2: Do log_flush in gfs2_ail_empty_gl even if ail list is empty
Before this patch, if gfs2_ail_empty_gl saw there was nothing on
the ail list, it would return and not flush the log. The problem
is that there could still be a revoke for the rgrp sitting on the
sd_log_le_revoke list that's been recently taken off the ail list.
But that revoke still needs to be written, and the rgrp_go_inval
still needs to call log_flush_wait to ensure the revokes are all
properly written to the journal before we relinquish control of
the glock to another node. If we give the glock to another node
before we have this knowledge, the node might crash and its journal
replayed, in which case the missing revoke would allow the journal
replay to replay the rgrp over top of the rgrp we already gave to
another node, thus overwriting its changes and corrupting the
file system.
This patch makes gfs2_ail_empty_gl still call gfs2_log_flush rather
than returning.
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'fs/gfs2/log.c')
-rw-r--r-- | fs/gfs2/log.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c index 578c1e0cd415..c37f81470792 100644 --- a/fs/gfs2/log.c +++ b/fs/gfs2/log.c @@ -537,7 +537,7 @@ static void log_pull_tail(struct gfs2_sbd *sdp, unsigned int new_tail) } -static void log_flush_wait(struct gfs2_sbd *sdp) +void log_flush_wait(struct gfs2_sbd *sdp) { DEFINE_WAIT(wait); |