diff options
| author | Bob Peterson <rpeterso@redhat.com> | 2021-07-30 20:23:49 +0200 |
|---|---|---|
| committer | Bob Peterson <rpeterso@redhat.com> | 2021-08-20 16:03:46 +0200 |
| commit | fffe9bee14b0e04ef632b96279fa44cb3df80812 (patch) | |
| tree | 62335d3b52439c15148456acff2f7a685b841a55 /fs/gfs2 | |
| parent | gfs2: Don't call dlm after protocol is unmounted (diff) | |
| download | linux-fffe9bee14b0e04ef632b96279fa44cb3df80812.tar.xz linux-fffe9bee14b0e04ef632b96279fa44cb3df80812.zip | |
gfs2: Delay withdraw from atomic context
Before this patch, if function __gfs2_ail_flush detected an error
syncing the ail list, it call gfs2_ail_error which called gfs2_withdraw.
Since __gfs2_ail_flush deals with a specific glock, we shouldn't withdraw
immediately because the withdraw code (signal_our_withdraw) uses glocks
in its processing.
This patch changes the call from gfs2_withdraw to gfs2_withdraw_delayed
which defers the withdraw until a more appropriate context, such as the
logd daemon, discovers the intent to withdraw.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Diffstat (limited to 'fs/gfs2')
| -rw-r--r-- | fs/gfs2/glops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index 5fbdc7e9f4ff..79c621c7863d 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c @@ -44,7 +44,7 @@ static void gfs2_ail_error(struct gfs2_glock *gl, const struct buffer_head *bh) gl->gl_name.ln_type, gl->gl_name.ln_number, gfs2_glock2aspace(gl)); gfs2_lm(sdp, "AIL error\n"); - gfs2_withdraw(sdp); + gfs2_withdraw_delayed(sdp); } /** |