diff options
author | Mathias Krause <minipli@grsecurity.net> | 2024-07-23 14:25:21 +0200 |
---|---|---|
committer | Steven Rostedt (Google) <rostedt@goodmis.org> | 2024-08-08 01:28:31 +0200 |
commit | 12c20c65d0460cf34f9a665d8f0c0d77d45a3829 (patch) | |
tree | e59a59491639fd4ee9b527895999898bf6b96c24 /fs/hfsplus | |
parent | tracefs: Fix inode allocation (diff) | |
download | linux-12c20c65d0460cf34f9a665d8f0c0d77d45a3829.tar.xz linux-12c20c65d0460cf34f9a665d8f0c0d77d45a3829.zip |
eventfs: Don't return NULL in eventfs_create_dir()
Commit 77a06c33a22d ("eventfs: Test for ei->is_freed when accessing
ei->dentry") added another check, testing if the parent was freed after
we released the mutex. If so, the function returns NULL. However, all
callers expect it to either return a valid pointer or an error pointer,
at least since commit 5264a2f4bb3b ("tracing: Fix a NULL vs IS_ERR() bug
in event_subsystem_dir()"). Returning NULL will therefore fail the error
condition check in the caller.
Fix this by substituting the NULL return value with a fitting error
pointer.
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: stable@vger.kernel.org
Fixes: 77a06c33a22d ("eventfs: Test for ei->is_freed when accessing ei->dentry")
Link: https://lore.kernel.org/20240723122522.2724-1-minipli@grsecurity.net
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Ajay Kaher <ajay.kaher@broadcom.com>
Signed-off-by: Mathias Krause <minipli@grsecurity.net>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Diffstat (limited to 'fs/hfsplus')
0 files changed, 0 insertions, 0 deletions