diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2018-06-08 19:01:49 +0200 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2018-07-12 16:04:17 +0200 |
| commit | 69527c554f82d4bca4b154ccc06ad1554806bdc0 (patch) | |
| tree | 5b920d336fac1fb8a0385228734f5156fce452b8 /fs/internal.h | |
| parent | lift fput() on late failures into path_openat() (diff) | |
| download | linux-69527c554f82d4bca4b154ccc06ad1554806bdc0.tar.xz linux-69527c554f82d4bca4b154ccc06ad1554806bdc0.zip | |
now we can fold open_check_o_direct() into do_dentry_open()
These checks are better off in do_dentry_open(); the reason we couldn't
put them there used to be that callers couldn't tell what kind of cleanup
would do_dentry_open() failure call for. Now that we have FMODE_OPENED,
cleanup is the same in all cases - it's simply fput(). So let's fold
that into do_dentry_open(), as Christoph's patch tried to.
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/internal.h')
| -rw-r--r-- | fs/internal.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/internal.h b/fs/internal.h index baeab53aeaff..52a346903748 100644 --- a/fs/internal.h +++ b/fs/internal.h @@ -125,7 +125,6 @@ int do_fchmodat(int dfd, const char __user *filename, umode_t mode); int do_fchownat(int dfd, const char __user *filename, uid_t user, gid_t group, int flag); -extern int open_check_o_direct(struct file *f); extern int vfs_open(const struct path *, struct file *); /* |