diff options
| author | Stefan Roesch <shr@fb.com> | 2022-02-25 19:53:26 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-03-10 17:33:55 +0100 |
| commit | 1b6fe6e0dfecf8c82a64fb87148ad9333fa2f62e (patch) | |
| tree | f5c41470131e67327323a593e14622429d36b76c /fs/internal.h | |
| parent | io_uring: Add support for napi_busy_poll (diff) | |
| download | linux-1b6fe6e0dfecf8c82a64fb87148ad9333fa2f62e.tar.xz linux-1b6fe6e0dfecf8c82a64fb87148ad9333fa2f62e.zip | |
io-uring: Make statx API stable
One of the key architectual tenets is to keep the parameters for
io-uring stable. After the call has been submitted, its value can
be changed. Unfortunaltely this is not the case for the current statx
implementation.
IO-Uring change:
This changes replaces the const char * filename pointer in the io_statx
structure with a struct filename *. In addition it also creates the
filename object during the prepare phase.
With this change, the opcode also needs to invoke cleanup, so the
filename object gets freed after processing the request.
fs change:
This replaces the const char* __user filename parameter in the two
functions do_statx and vfs_statx with a struct filename *. In addition
to be able to correctly construct a filename object a new helper
function getname_statx_lookup_flags is introduced. The function makes
sure that do_statx and vfs_statx is invoked with the correct lookup flags.
Signed-off-by: Stefan Roesch <shr@fb.com>
Link: https://lore.kernel.org/r/20220225185326.1373304-2-shr@fb.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/internal.h')
| -rw-r--r-- | fs/internal.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/internal.h b/fs/internal.h index 8590c973c2f4..56c0477f4215 100644 --- a/fs/internal.h +++ b/fs/internal.h @@ -184,7 +184,9 @@ int sb_init_dio_done_wq(struct super_block *sb); /* * fs/stat.c: */ -int do_statx(int dfd, const char __user *filename, unsigned flags, + +int getname_statx_lookup_flags(int flags); +int do_statx(int dfd, struct filename *filename, unsigned int flags, unsigned int mask, struct statx __user *buffer); /* |