summaryrefslogtreecommitdiffstats
path: root/fs/internal.h
diff options
context:
space:
mode:
authorTal Zussman <tz2294@columbia.edu>2021-12-31 08:57:50 +0100
committerAl Viro <viro@zeniv.linux.org.uk>2022-01-30 20:34:55 +0100
commitc51acdb78f92719127995c0fe41108df0552edc3 (patch)
tree14c5041e3a5a26ac1e1a7d1783b06730bc169c3f /fs/internal.h
parentLinux 5.17-rc1 (diff)
downloadlinux-c51acdb78f92719127995c0fe41108df0552edc3.tar.xz
linux-c51acdb78f92719127995c0fe41108df0552edc3.zip
fs: Remove FIXME comment in generic_write_checks()
This patch removes an unnecessary comment that had to do with block special files from `generic_write_checks()`. The comment, originally added in Linux v2.4.14.9, was to clarify that we only set `pos` to the file size when the file was opened with `O_APPEND` if the file wasn't a block special file. Prior to Linux v2.4, block special files had a different `write()` function which was unified into a generic `write()` function in Linux v2.4. This generic `write()` function called `generic_write_checks()`. For more details, see this earlier conversation: https://lore.kernel.org/linux-fsdevel/Yc4Czk5A+p5p2Y4W@mit.edu/ Currently, block special devices have their own `write_iter()` function and no longer share the same `generic_write_checks()`, therefore rendering the comment irrelevant. Signed-off-by: Tal Zussman <tz2294@columbia.edu> Co-authored-by: Xijiao Li <xl2950@columbia.edu> Co-authored-by: Hans Montero <hjm2133@columbia.edu> Suggested-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/internal.h')
0 files changed, 0 insertions, 0 deletions