diff options
| author | Jens Axboe <axboe@kernel.dk> | 2021-10-25 21:45:12 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2021-10-26 23:54:40 +0200 |
| commit | 3884b83dff245e41def99ceacca8ed2056baf0a8 (patch) | |
| tree | 501178976d63bda38daa182f8a5ee4bb79fde5bd /fs/io_uring.c | |
| parent | io_uring: clusterise ki_flags access in rw_prep (diff) | |
| download | linux-3884b83dff245e41def99ceacca8ed2056baf0a8.tar.xz linux-3884b83dff245e41def99ceacca8ed2056baf0a8.zip | |
io_uring: don't assign write hint in the read path
Move this out of the generic read/write prep path, and place it in the
write specific kiocb setup instead.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/io_uring.c')
| -rw-r--r-- | fs/io_uring.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/io_uring.c b/fs/io_uring.c index bba2f77ae7e7..d001cd7a6c51 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -2825,7 +2825,6 @@ static int io_prep_rw(struct io_kiocb *req, const struct io_uring_sqe *sqe) req->flags |= REQ_F_CUR_POS; kiocb->ki_pos = file->f_pos; } - kiocb->ki_hint = ki_hint_validate(file_write_hint(file)); kiocb->ki_flags = iocb_flags(file); ret = kiocb_set_rw_flags(kiocb, READ_ONCE(sqe->rw_flags)); if (unlikely(ret)) @@ -3568,6 +3567,7 @@ static int io_write_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) { if (unlikely(!(req->file->f_mode & FMODE_WRITE))) return -EBADF; + req->rw.kiocb.ki_hint = ki_hint_validate(file_write_hint(req->file)); return io_prep_rw(req, sqe); } |