summaryrefslogtreecommitdiffstats
path: root/fs/iomap
diff options
context:
space:
mode:
authorDarrick J. Wong <djwong@kernel.org>2023-09-11 17:39:03 +0200
committerDarrick J. Wong <djwong@kernel.org>2023-09-11 17:39:03 +0200
commit62334fab47621dd91ab30dd5bb6c43d78a8ec279 (patch)
tree76f83feb49fd1a2d9529f99b6225364be52d8dd7 /fs/iomap
parentxfs: fix per-cpu CIL structure aggregation racing with dying cpus (diff)
downloadlinux-62334fab47621dd91ab30dd5bb6c43d78a8ec279.tar.xz
linux-62334fab47621dd91ab30dd5bb6c43d78a8ec279.zip
xfs: use per-mount cpumask to track nonempty percpu inodegc lists
Directly track which CPUs have contributed to the inodegc percpu lists instead of trusting the cpu online mask. This eliminates a theoretical problem where the inodegc flush functions might fail to flush a CPU's inodes if that CPU happened to be dying at exactly the same time. Most likely nobody's noticed this because the CPU dead hook moves the percpu inodegc list to another CPU and schedules that worker immediately. But it's quite possible that this is a subtle race leading to UAF if the inodegc flush were part of an unmount. Further benefits: This reduces the overhead of the inodegc flush code slightly by allowing us to ignore CPUs that have empty lists. Better yet, it reduces our dependence on the cpu online masks, which have been the cause of confusion and drama lately. Fixes: ab23a7768739 ("xfs: per-cpu deferred inode inactivation queues") Signed-off-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Dave Chinner <dchinner@redhat.com>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions