diff options
| author | Ritesh Harjani (IBM) <ritesh.list@gmail.com> | 2023-04-21 17:52:43 +0200 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2023-04-21 17:54:47 +0200 |
| commit | d3bff1fc50d4fcaccddbd63917dd94172e80c40e (patch) | |
| tree | 2230bd2216e1d392eea1a9780a8ce70a7365cc08 /fs/iomap | |
| parent | fs.h: Add TRACE_IOCB_STRINGS for use in trace points (diff) | |
| download | linux-d3bff1fc50d4fcaccddbd63917dd94172e80c40e.tar.xz linux-d3bff1fc50d4fcaccddbd63917dd94172e80c40e.zip | |
iomap: Remove IOMAP_DIO_NOSYNC unused dio flag
IOMAP_DIO_NOSYNC earlier was added for use in btrfs. But it seems for
aio dsync writes this is not useful anyway. For aio dsync case, we
we queue the request and return -EIOCBQUEUED. Now, since IOMAP_DIO_NOSYNC
doesn't let iomap_dio_complete() to call generic_write_sync(),
hence we may lose the sync write.
Hence kill this flag as it is not in use by any FS now.
Tested-by: Disha Goel <disgoel@linux.ibm.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Diffstat (limited to 'fs/iomap')
| -rw-r--r-- | fs/iomap/direct-io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index f771001574d0..36ab1152dbea 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -541,7 +541,7 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, } /* for data sync or sync, we need sync completion processing */ - if (iocb_is_dsync(iocb) && !(dio_flags & IOMAP_DIO_NOSYNC)) { + if (iocb_is_dsync(iocb)) { dio->flags |= IOMAP_DIO_NEED_SYNC; /* |