diff options
| author | Ritesh Harjani (IBM) <ritesh.list@gmail.com> | 2023-07-10 23:12:22 +0200 |
|---|---|---|
| committer | Ritesh Harjani (IBM) <ritesh.list@gmail.com> | 2023-07-25 07:25:55 +0200 |
| commit | eee2d2e6ea5550118170dbd5bb1316ceb38455fb (patch) | |
| tree | 76507a749a9fc86e2970548f726509cb9642e253 /fs/iomap | |
| parent | iomap: Add some uptodate state handling helpers for ifs state bitmap (diff) | |
| download | linux-eee2d2e6ea5550118170dbd5bb1316ceb38455fb.tar.xz linux-eee2d2e6ea5550118170dbd5bb1316ceb38455fb.zip | |
iomap: Fix possible overflow condition in iomap_write_delalloc_scan
folio_next_index() returns an unsigned long value which left shifted
by PAGE_SHIFT could possibly cause an overflow on 32-bit system. Instead
use folio_pos(folio) + folio_size(folio), which does this correctly.
Suggested-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Diffstat (limited to 'fs/iomap')
| -rw-r--r-- | fs/iomap/buffered-io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c index 85159e5b3d1d..38e95302bd6a 100644 --- a/fs/iomap/buffered-io.c +++ b/fs/iomap/buffered-io.c @@ -934,7 +934,7 @@ static int iomap_write_delalloc_scan(struct inode *inode, * the end of this data range, not the end of the folio. */ *punch_start_byte = min_t(loff_t, end_byte, - folio_next_index(folio) << PAGE_SHIFT); + folio_pos(folio) + folio_size(folio)); } /* move offset to start of next folio in range */ |