diff options
| author | Jonas Bonn <jonas.bonn@gmail.com> | 2008-01-18 00:21:13 +0100 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-01-18 00:38:59 +0100 |
| commit | f63dcda197bd71c6565c2121bf70e3d371539f90 (patch) | |
| tree | d0c64161017788d0dddd59687859ac0a67d0ad07 /fs/jbd/transaction.c | |
| parent | mm: fix section mismatch warning in page_alloc.c (diff) | |
| download | linux-f63dcda197bd71c6565c2121bf70e3d371539f90.tar.xz linux-f63dcda197bd71c6565c2121bf70e3d371539f90.zip | |
jbd: do not try lock_acquire after handle made invalid
This likely fixes the oops in __lock_acquire reported as:
http://www.kerneloops.org/raw.php?rawid=2753&msgid=
http://www.kerneloops.org/raw.php?rawid=2749&msgid=
In these reported oopses, start_this_handle is returning -EROFS.
Signed-off-by: Jonas Bonn <jonas.bonn@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/jbd/transaction.c')
| -rw-r--r-- | fs/jbd/transaction.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c index 08ff6c7028cc..038ed7436199 100644 --- a/fs/jbd/transaction.c +++ b/fs/jbd/transaction.c @@ -288,10 +288,12 @@ handle_t *journal_start(journal_t *journal, int nblocks) jbd_free_handle(handle); current->journal_info = NULL; handle = ERR_PTR(err); + goto out; } lock_acquire(&handle->h_lockdep_map, 0, 0, 0, 2, _THIS_IP_); +out: return handle; } |