diff options
author | Akira Fujita <a-fujita@rs.jp.nec.com> | 2009-12-07 05:38:31 +0100 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2009-12-07 05:38:31 +0100 |
commit | 4a58579b9e4e2a35d57e6c9c8483e52f6f1b7fd6 (patch) | |
tree | f3a7f898a081d0917f7fe7f051aba687308cbf0a /fs/jbd2 | |
parent | ext4: Wait for proper transaction commit on fsync (diff) | |
download | linux-4a58579b9e4e2a35d57e6c9c8483e52f6f1b7fd6.tar.xz linux-4a58579b9e4e2a35d57e6c9c8483e52f6f1b7fd6.zip |
ext4: Fix insufficient checks in EXT4_IOC_MOVE_EXT
This patch fixes three problems in the handling of the
EXT4_IOC_MOVE_EXT ioctl:
1. In current EXT4_IOC_MOVE_EXT, there are read access mode checks for
original and donor files, but they allow the illegal write access to
donor file, since donor file is overwritten by original file data. To
fix this problem, change access mode checks of original (r->r/w) and
donor (r->w) files.
2. Disallow the use of donor files that have a setuid or setgid bits.
3. Call mnt_want_write() and mnt_drop_write() before and after
ext4_move_extents() calling to get write access to a mount.
Signed-off-by: Akira Fujita <a-fujita@rs.jp.nec.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/jbd2')
0 files changed, 0 insertions, 0 deletions