diff options
| author | Dave Kleikamp <shaggy@linux.vnet.ibm.com> | 2007-05-05 21:24:05 +0200 |
|---|---|---|
| committer | Dave Kleikamp <shaggy@linux.vnet.ibm.com> | 2007-05-05 21:24:05 +0200 |
| commit | 05ec9e26be1f668ccba4ca54d9a4966c6208c611 (patch) | |
| tree | f05d3437dd0f0623b139e109fe8a53e5ea336696 /fs/jfs | |
| parent | JFS: use __set_current_state() (diff) | |
| download | linux-05ec9e26be1f668ccba4ca54d9a4966c6208c611.tar.xz linux-05ec9e26be1f668ccba4ca54d9a4966c6208c611.zip | |
JFS: Fix race waking up jfsIO kernel thread
It's possible for a journal I/O request to be added to the log_redrive
queue and the jfsIO thread to be awakened after the thread releases
log_redrive_lock but before it sets its state to TASK_INTERRUPTIBLE.
The jfsIO thread should set the state before giving up the spinlock, so
the waking thread will really wake it.
Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com>
Diffstat (limited to 'fs/jfs')
| -rw-r--r-- | fs/jfs/jfs_logmgr.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index ff7f1beec30d..16c62680fcd6 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c @@ -2354,12 +2354,13 @@ int jfsIOWait(void *arg) lbmStartIO(bp); spin_lock_irq(&log_redrive_lock); } - spin_unlock_irq(&log_redrive_lock); if (freezing(current)) { + spin_unlock_irq(&log_redrive_lock); refrigerator(); } else { set_current_state(TASK_INTERRUPTIBLE); + spin_unlock_irq(&log_redrive_lock); schedule(); __set_current_state(TASK_RUNNING); } |