diff options
| author | Marios Makassikis <mmakassikis@freebox.fr> | 2023-03-16 14:40:43 +0100 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2023-03-25 20:54:06 +0100 |
| commit | e416ea62a9166e6075a07a970cc5bf79255d2700 (patch) | |
| tree | 0fb404168995e112ea94216140748d341a9a3282 /fs/ksmbd | |
| parent | Merge tag '6.3-rc3-ksmbd-smb3-server-fixes' of git://git.samba.org/ksmbd (diff) | |
| download | linux-e416ea62a9166e6075a07a970cc5bf79255d2700.tar.xz linux-e416ea62a9166e6075a07a970cc5bf79255d2700.zip | |
ksmbd: do not call kvmalloc() with __GFP_NORETRY | __GFP_NO_WARN
Commit 83dcedd5540d ("ksmbd: fix infinite loop in ksmbd_conn_handler_loop()"),
changes GFP modifiers passed to kvmalloc(). This cause xfstests generic/551
test to fail. We limit pdu length size according to connection status and
maximum number of connections. In the rest, memory allocation of request
is limited by credit management. so these flags are no longer needed.
Fixes: 83dcedd5540d ("ksmbd: fix infinite loop in ksmbd_conn_handler_loop()")
Cc: stable@vger.kernel.org
Signed-off-by: Marios Makassikis <mmakassikis@freebox.fr>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/ksmbd')
| -rw-r--r-- | fs/ksmbd/connection.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/ksmbd/connection.c b/fs/ksmbd/connection.c index 115a67d2cf78..3f5dfebaa041 100644 --- a/fs/ksmbd/connection.c +++ b/fs/ksmbd/connection.c @@ -326,10 +326,7 @@ int ksmbd_conn_handler_loop(void *p) /* 4 for rfc1002 length field */ size = pdu_size + 4; - conn->request_buf = kvmalloc(size, - GFP_KERNEL | - __GFP_NOWARN | - __GFP_NORETRY); + conn->request_buf = kvmalloc(size, GFP_KERNEL); if (!conn->request_buf) break; |