diff options
| author | Jann Horn <jannh@google.com> | 2020-03-05 23:06:57 +0100 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2020-04-30 20:14:38 +0200 |
| commit | 586b58cac8b4683eb58a1446fbc399de18974e40 (patch) | |
| tree | a31aa2ff43c541f2ee7d098369379effb2ffffe4 /fs/libfs.c | |
| parent | sched/fair: Simplify the code of should_we_balance() (diff) | |
| download | linux-586b58cac8b4683eb58a1446fbc399de18974e40.tar.xz linux-586b58cac8b4683eb58a1446fbc399de18974e40.zip | |
exit: Move preemption fixup up, move blocking operations down
With CONFIG_DEBUG_ATOMIC_SLEEP=y and CONFIG_CGROUPS=y, kernel oopses in
non-preemptible context look untidy; after the main oops, the kernel prints
a "sleeping function called from invalid context" report because
exit_signals() -> cgroup_threadgroup_change_begin() -> percpu_down_read()
can sleep, and that happens before the preempt_count_set(PREEMPT_ENABLED)
fixup.
It looks like the same thing applies to profile_task_exit() and
kcov_task_exit().
Fix it by moving the preemption fixup up and the calls to
profile_task_exit() and kcov_task_exit() down.
Fixes: 1dc0fffc48af ("sched/core: Robustify preemption leak checks")
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200305220657.46800-1-jannh@google.com
Diffstat (limited to 'fs/libfs.c')
0 files changed, 0 insertions, 0 deletions