diff options
| author | Al Viro <viro@ftp.linux.org.uk> | 2006-10-20 08:28:44 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-20 19:26:39 +0200 |
| commit | cc45f0175088e000ac7493e5e3f05579b6f7d240 (patch) | |
| tree | cc53e59824097b45a39ca332b3451aedc43d4fe2 /fs/lockd/xdr4.c | |
| parent | [PATCH] SUNRPC: fix a typo (diff) | |
| download | linux-cc45f0175088e000ac7493e5e3f05579b6f7d240.tar.xz linux-cc45f0175088e000ac7493e5e3f05579b6f7d240.zip | |
[PATCH] bug: nfsd/nfs4xdr.c misuse of ERR_PTR()
a) ERR_PTR(nfserr_something) is a bad idea;
IS_ERR() will be false for it.
b) mixing nfserr_.... with -EOPNOTSUPP is
even worse idea.
nfsd4_path() does both; caller expects to get NFS protocol error out it if
anything goes wrong, but if it does we either do not notice (see (a)) or get
host-endian negative (see (b)).
IOW, that's a case when we can't use ERR_PTR() to return error, even though we
return a pointer in case of success.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Trond Myklebust <trond.myklebust@fys.uio.no>
Acked-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/lockd/xdr4.c')
0 files changed, 0 insertions, 0 deletions