diff options
| author | J. Bruce Fields <bfields@redhat.com> | 2012-08-17 23:31:53 +0200 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2012-08-21 00:39:19 +0200 |
| commit | d10f27a750312ed5638c876e4bd6aa83664cccd8 (patch) | |
| tree | 9d6c68a078bc5129080177829d531d2686ea4e2a /fs/locks.c | |
| parent | svcrpc: sends on closed socket should stop immediately (diff) | |
| download | linux-d10f27a750312ed5638c876e4bd6aa83664cccd8.tar.xz linux-d10f27a750312ed5638c876e4bd6aa83664cccd8.zip | |
svcrpc: fix svc_xprt_enqueue/svc_recv busy-looping
The rpc server tries to ensure that there will be room to send a reply
before it receives a request.
It does this by tracking, in xpt_reserved, an upper bound on the total
size of the replies that is has already committed to for the socket.
Currently it is adding in the estimate for a new reply *before* it
checks whether there is space available. If it finds that there is not
space, it then subtracts the estimate back out.
This may lead the subsequent svc_xprt_enqueue to decide that there is
space after all.
The results is a svc_recv() that will repeatedly return -EAGAIN, causing
server threads to loop without doing any actual work.
Cc: stable@vger.kernel.org
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Tested-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/locks.c')
0 files changed, 0 insertions, 0 deletions