diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2011-03-09 07:34:45 +0100 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2011-03-14 14:15:27 +0100 |
| commit | f374ed5fa8afed8590deaae5dc147422e0e1a6d9 (patch) | |
| tree | 76bf116e7a8c75be60734527dd804632dee8a95b /fs/namei.c | |
| parent | fold __open_namei_create() and open_will_truncate() into do_last() (diff) | |
| download | linux-f374ed5fa8afed8590deaae5dc147422e0e1a6d9.tar.xz linux-f374ed5fa8afed8590deaae5dc147422e0e1a6d9.zip | |
do_last: kill a rudiment of old ->d_revalidate() workaround
There used to be time when ->d_revalidate() couldn't return an error.
So intents code had lookup_instantiate_filp() stash ERR_PTR(error)
in nd->intent.open.filp and had it checked after lookup_hash(), to
catch the otherwise silent failures. That had been introduced by
commit 4af4c52f34606bdaab6930a845550c6fb02078a4. These days
->d_revalidate() can and does propagate errors back to callers
explicitly, so this check isn't needed anymore.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to '')
| -rw-r--r-- | fs/namei.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/fs/namei.c b/fs/namei.c index 441f1106de08..6972e761286b 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -2183,11 +2183,6 @@ static struct file *do_last(struct nameidata *nd, struct path *path, path->dentry = dentry; path->mnt = nd->path.mnt; - if (IS_ERR(nd->intent.open.file)) { - error = PTR_ERR(nd->intent.open.file); - goto exit_mutex_unlock; - } - /* Negative dentry, just create the file */ if (!dentry->d_inode) { int mode = op->mode; |