diff options
author | Steve Langasek <vorlon@debian.org> | 2006-02-07 21:58:35 +0100 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-02-08 01:12:31 +0100 |
commit | c00a76aea339b427b47ddc28de06dee0a652e801 (patch) | |
tree | be6267266d399952f54a2fd4d991a610bb42b43a /fs/namei.c | |
parent | [PATCH] ide: cast arguments to pr_debug() properly (diff) | |
download | linux-c00a76aea339b427b47ddc28de06dee0a652e801.tar.xz linux-c00a76aea339b427b47ddc28de06dee0a652e801.zip |
[PATCH] __cmpxchg() must really always be inlined on alpha
With the latest 2.6.15 kernel builds for alpha on Debian, we ran into a
problem with undefined references to __cmpxchg_called_with_bad_pointer() in
a couple of kernel modules (xfs.ko and drm.ko; see
http://bugs.debian.org/347556).
It looks like people have been trying to out-clever each other wrt the
definition of "inline" on this architecture :), with the result that
__cmpxchg(), which must be inlined so the compiler can see its argument is
const, is not guaranteed to be inlined. Indeed, it was not being inlined
when building with -Os.
The attached patch fixes the issue by adding an
__attribute__((always_inline)) explicitly to the definition of __cmpxchg()
instead of relying on redefines of "inline" elsewhere to make this happen.
Cc: Richard Henderson <rth@twiddle.net>
Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/namei.c')
0 files changed, 0 insertions, 0 deletions