summaryrefslogtreecommitdiffstats
path: root/fs/namei.c
diff options
context:
space:
mode:
authorMiklos Szeredi <mszeredi@suse.cz>2012-08-15 13:01:24 +0200
committerMiklos Szeredi <mszeredi@suse.cz>2012-08-15 13:01:24 +0200
commit62b259d8b3ea9d4a73108fc599e40c863ec25ae6 (patch)
tree8c4cdd05f37a3358aad90a5977d8ec1fc5c935cc /fs/namei.c
parentvfs: canonicalize create mode in build_open_flags() (diff)
downloadlinux-62b259d8b3ea9d4a73108fc599e40c863ec25ae6.tar.xz
linux-62b259d8b3ea9d4a73108fc599e40c863ec25ae6.zip
vfs: atomic_open(): fix create mode usage
Don't mask S_ISREG off the create mode before passing to ->atomic_open(). Other methods (->create, ->mknod) also get the complete file mode and filesystems expect it. Reported-by: Steve <steveamigauk@yahoo.co.uk> Reported-by: Richard W.M. Jones <rjones@redhat.com> Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> Tested-by: Richard W.M. Jones <rjones@redhat.com>
Diffstat (limited to 'fs/namei.c')
-rw-r--r--fs/namei.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/namei.c b/fs/namei.c
index 1b464390dde8..5bac1bb6e585 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2414,7 +2414,7 @@ static int atomic_open(struct nameidata *nd, struct dentry *dentry,
goto out;
}
- mode = op->mode & S_IALLUGO;
+ mode = op->mode;
if ((open_flag & O_CREAT) && !IS_POSIXACL(dir))
mode &= ~current_umask();