diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2006-10-20 08:28:41 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-20 19:26:39 +0200 |
| commit | 39cf8a1374dc51fea169190674d5e4996a7d7ea2 (patch) | |
| tree | ca6e201861ed911c2b78dd81b56505527308c9a4 /fs/nfs/dir.c | |
| parent | [PATCH] NFS: Deal with failure of invalidate_inode_pages2() (diff) | |
| download | linux-39cf8a1374dc51fea169190674d5e4996a7d7ea2.tar.xz linux-39cf8a1374dc51fea169190674d5e4996a7d7ea2.zip | |
[PATCH] NFS: fix minor bug in new NFS symlink code
The original code confused a zero return code from pagevec_add() as success.
Test plan:
None.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/nfs/dir.c')
| -rw-r--r-- | fs/nfs/dir.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 58d44057813e..c86a1ead4772 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -1519,8 +1519,8 @@ static int nfs_symlink(struct inode *dir, struct dentry *dentry, const char *sym pagevec_init(&lru_pvec, 0); if (!add_to_page_cache(page, dentry->d_inode->i_mapping, 0, GFP_KERNEL)) { - if (!pagevec_add(&lru_pvec, page)) - __pagevec_lru_add(&lru_pvec); + pagevec_add(&lru_pvec, page); + pagevec_lru_add(&lru_pvec); SetPageUptodate(page); unlock_page(page); } else |