diff options
author | Su Yanjun <suyanjun218@gmail.com> | 2019-12-25 04:37:57 +0100 |
---|---|---|
committer | Anna Schumaker <Anna.Schumaker@Netapp.com> | 2020-01-15 16:54:33 +0100 |
commit | fe1e8dbec11fcad3ae7a34e95fe483d4a2b018fc (patch) | |
tree | 97ddfcfee8598ec79a13cf5696a6e140656eb636 /fs/nfs/dir.c | |
parent | NFSv4.x recover from pre-mature loss of openstateid (diff) | |
download | linux-fe1e8dbec11fcad3ae7a34e95fe483d4a2b018fc.tar.xz linux-fe1e8dbec11fcad3ae7a34e95fe483d4a2b018fc.zip |
NFSv3: FIx bug when using chacl and chmod to change acl
We find a bug when running test under nfsv3 as below.
1)
chacl u::r--,g::rwx,o:rw- file1
2)
chmod u+w file1
3)
chacl -l file1
We expect u::rw-, but it shows u::r--, more likely it returns the
cached acl in inode.
We dig the code find that the code path is different.
chacl->..->__nfs3_proc_setacls->nfs_zap_acl_cache
Then nfs_zap_acl_cache clears the NFS_INO_INVALID_ACL in
NFS_I(inode)->cache_validity.
chmod->..->nfs3_proc_setattr
Because NFS_INO_INVALID_ACL has been cleared by chacl path,
nfs_zap_acl_cache wont be called.
nfs_setattr_update_inode will set NFS_INO_INVALID_ACL so let it
before nfs_zap_acl_cache call.
Signed-off-by: Su Yanjun <suyanjun218@gmail.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'fs/nfs/dir.c')
0 files changed, 0 insertions, 0 deletions