summaryrefslogtreecommitdiffstats
path: root/fs/nfs/direct.c
diff options
context:
space:
mode:
authorTrond Myklebust <trond.myklebust@hammerspace.com>2019-02-18 17:35:54 +0100
committerTrond Myklebust <trond.myklebust@hammerspace.com>2019-02-20 21:14:20 +0100
commit078b5fd92c4913dd367361db6c28568386077c89 (patch)
tree050fdb065ff9ae968b9cfad355ab3213874da44d /fs/nfs/direct.c
parentNFS: Don't recoalesce on error in nfs_pageio_complete_mirror() (diff)
downloadlinux-078b5fd92c4913dd367361db6c28568386077c89.tar.xz
linux-078b5fd92c4913dd367361db6c28568386077c89.zip
NFS: Clean up list moves of struct nfs_page
In several places we're just moving the struct nfs_page from one list to another by first removing from the existing list, then adding to the new one. Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Diffstat (limited to 'fs/nfs/direct.c')
-rw-r--r--fs/nfs/direct.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
index 33824a0a57bf..1377ee20ecf9 100644
--- a/fs/nfs/direct.c
+++ b/fs/nfs/direct.c
@@ -664,8 +664,7 @@ static void nfs_direct_write_reschedule(struct nfs_direct_req *dreq)
list_for_each_entry_safe(req, tmp, &reqs, wb_list) {
if (!nfs_pageio_add_request(&desc, req)) {
- nfs_list_remove_request(req);
- nfs_list_add_request(req, &failed);
+ nfs_list_move_request(req, &failed);
spin_lock(&cinfo.inode->i_lock);
dreq->flags = 0;
if (desc.pg_error < 0)