summaryrefslogtreecommitdiffstats
path: root/fs/nfs/nfs4proc.c
diff options
context:
space:
mode:
authorNick Desaulniers <ndesaulniers@google.com>2020-09-17 23:45:45 +0200
committerAnna Schumaker <Anna.Schumaker@Netapp.com>2020-10-02 14:43:08 +0200
commitfb08334bb38f56d308d3e15b47bca67529cffc87 (patch)
treec0e7ac1b4ff75c50462bea84ce3f5bc0020d06f7 /fs/nfs/nfs4proc.c
parentNFSv4: make cache consistency bitmask dynamic (diff)
downloadlinux-fb08334bb38f56d308d3e15b47bca67529cffc87.tar.xz
linux-fb08334bb38f56d308d3e15b47bca67529cffc87.zip
nfs: remove incorrect fallthrough label
There is no case after the default from which to fallthrough to. Clang will error in this case (unhelpfully without context, see link below) and GCC will with -Wswitch-unreachable. The previous commit should have just replaced the comment with a break statement. If we consider implicit fallthrough to be a design mistake of C, then all case statements should be terminated with one of the following statements: * break * continue * return * fallthrough * goto * (call of function with __attribute__(__noreturn__)) Fixes: 2a1390c95a69 ("nfs: Convert to use the preferred fallthrough macro") Link: https://bugs.llvm.org/show_bug.cgi?id=47539 Acked-by: Gustavo A. R. Silva <gustavoars@kernel.org> Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Suggested-by: Joe Perches <joe@perches.com> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Diffstat (limited to 'fs/nfs/nfs4proc.c')
0 files changed, 0 insertions, 0 deletions