diff options
| author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2011-06-10 19:30:22 +0200 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2011-06-21 17:54:05 +0200 |
| commit | 8f7d5efbef8718a774ac5e347b4ec069f17fd9b4 (patch) | |
| tree | aa95020eb43fe3cdb45ce96c9ec024b92f5c7621 /fs/nfs/objlayout/objio_osd.c | |
| parent | NFSv4.1: file layout must consider pg_bsize for coalescing (diff) | |
| download | linux-8f7d5efbef8718a774ac5e347b4ec069f17fd9b4.tar.xz linux-8f7d5efbef8718a774ac5e347b4ec069f17fd9b4.zip | |
NFSv4.1: Fix some issues with pnfs_generic_pg_test
1. If the intention is to coalesce requests 'prev' and 'req' then we
have to ensure at least that we have a layout starting at
req_offset(prev).
2. If we're only requesting a minimal layout of length desc->pg_count,
we need to test the length actually returned by the server before
we allow the coalescing to occur.
3. We need to deal correctly with (pgio->lseg == NULL)
4. Fixup the test guarding the pnfs_update_layout.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs/nfs/objlayout/objio_osd.c')
| -rw-r--r-- | fs/nfs/objlayout/objio_osd.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/nfs/objlayout/objio_osd.c b/fs/nfs/objlayout/objio_osd.c index eb4aafa9f521..8ff2ea3f10ef 100644 --- a/fs/nfs/objlayout/objio_osd.c +++ b/fs/nfs/objlayout/objio_osd.c @@ -1000,6 +1000,9 @@ static bool objio_pg_test(struct nfs_pageio_descriptor *pgio, if (!pnfs_generic_pg_test(pgio, prev, req)) return false; + if (pgio->pg_lseg == NULL) + return true; + return pgio->pg_count + req->wb_bytes <= OBJIO_LSEG(pgio->pg_lseg)->max_io_size; } |