summaryrefslogtreecommitdiffstats
path: root/fs/nfs/write.c
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.com>2017-08-18 09:12:51 +0200
committerTrond Myklebust <trond.myklebust@primarydata.com>2017-09-06 18:31:15 +0200
commit237f8306c30206d997e265ff46652e602a50824f (patch)
treeed84a06c04bdbff5c6d033c70c89da012298c95c /fs/nfs/write.c
parentxprtrdma: Use xprt_pin_rqst in rpcrdma_reply_handler (diff)
downloadlinux-237f8306c30206d997e265ff46652e602a50824f.tar.xz
linux-237f8306c30206d997e265ff46652e602a50824f.zip
NFS: don't expect errors from mempool_alloc().
Commit fbe77c30e9ab ("NFS: move rw_mode to nfs_pageio_header") reintroduced some pointless code that commit 518662e0fcb9 ("NFS: fix usage of mempools.") had recently removed. Remove it again. Cc: Benjamin Coddington <bcodding@redhat.com> Signed-off-by: NeilBrown <neilb@suse.com> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to '')
-rw-r--r--fs/nfs/write.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 1a877d17e6cb..ae26775b5448 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -102,10 +102,8 @@ static struct nfs_pgio_header *nfs_writehdr_alloc(void)
{
struct nfs_pgio_header *p = mempool_alloc(nfs_wdata_mempool, GFP_NOIO);
- if (p) {
- memset(p, 0, sizeof(*p));
- p->rw_mode = FMODE_WRITE;
- }
+ memset(p, 0, sizeof(*p));
+ p->rw_mode = FMODE_WRITE;
return p;
}